Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add case/control output file #3

Merged
merged 3 commits into from
Dec 22, 2022
Merged

Add case/control output file #3

merged 3 commits into from
Dec 22, 2022

Conversation

jameeters
Copy link
Member

@jameeters jameeters commented Dec 19, 2022 •
edited
Loading

@jameeters jameeters mentioned this pull request Dec 19, 2022
Merged
rcoleb
rcoleb requested changes Dec 21, 2022
View reviewed changes
Copy link
Member

@rcoleb rcoleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note on PrintWriters, otherwise no other issues.

src/main/java/org/pankratzlab/kdmatch/KDMatch.java Outdated Show resolved Hide resolved
src/main/java/org/pankratzlab/kdmatch/Match.java Show resolved Hide resolved
@jameeters
Copy link
Member Author

I've made a couple changes to close that printWriter and deal with the case where numToSelect is too large

@jameeters jameeters merged commit 1aa4bde into master Dec 22, 2022
@jameeters jameeters deleted the sample_status_output branch December 22, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlanej jlanej jlanej left review comments

@rcoleb rcoleb rcoleb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jameeters @rcoleb @jlanej