Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for target_version.minor in update #216

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

seanyoungberg
Copy link
Contributor

Fix typo in comparison for _direct_upgrade_possible() function in updater.py

Description

Fix typo

Motivation and Context

Noticed when trying to use updater.py to upgrade from 9.0.5.xfr -> 9.1.2

#215

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@btorresgil btorresgil self-requested a review April 14, 2020 21:55
@btorresgil
Copy link
Member

Thanks for the PR. Strange, this has been working for years, I have used it in countless upgrades. But you clearly found an issue.

I want to fully understand this before merging. Give me some time to write some unittests around it. I think there might be another issue here going undetected.

Thanks again!

@btorresgil btorresgil merged commit 4269200 into PaloAltoNetworks:develop Jun 17, 2020
@welcome
Copy link

welcome bot commented Jun 17, 2020

🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️

@btorresgil btorresgil linked an issue Jun 17, 2020 that may be closed by this pull request
github-actions bot pushed a commit that referenced this pull request Jul 24, 2020
## 1.0.0-alpha.1 (2020-07-24)

### Features

*  IP Classification and easier field usage.  Fields added:  user, src_class, dst_class, server_ip, server_location, client_ip, client_location.  Note that client_ip was already in use by the config logs and dashboard, so that client_ip field is renamed to admin_ip, and the client_type field is renamed to admin_type.  This is done to avoid naming conflicts. ([f2405cb](f2405cb))
*  New App highlighting.  When apps are added to the master Palo Alto Networks applipedia, Splunk will get the apps and index them.  Then, dashboard panels can be created to show when new apps are added, or if any traffic in the network is matching these new apps. ([550fca6](550fca6))
* Add normalized objects for firewall and Panorama commits ([0983558](0983558)), closes [#220](#220)
* Add support for wildcard address objects ([e859ff6](e859ff6)), closes [#228](#228) [#226](#226)
* Support for Dynamic Address Groups and Dynamic Address Objects (IP address tagging). This feature is utilized similarly to 'panblock', but the command is 'pantag'. ([8753410](8753410))

### Bug Fixes

* config field 'host' overlapped with Splunk default field 'host'.  Changed to 'client_ip'.  Changed 'client' to 'client_type'. ([5bb9a9f](5bb9a9f))
* config field 'host' overlapped with Splunk default field 'host'.  Changed to 'client_ip'.  Changed 'client' to 'client_type'. ([d1f5e76](d1f5e76))
* Correct how target_version is determined ([4269200](4269200)), closes [#216](#216)
* Fix tag-allowed property of VirtualWire ([f02143e](f02143e)), closes [#232](#232) [#221](#221)
* if there are no registered addresses iterator will throw exception ([eabfbd9](eabfbd9))

### Reverts

* Revert "Added a Splunk 6 Data Model to represent the Palo Alto Networks log structure. Currently this model is NOT accelerated due to known Splunk issue (SPL-74415)" ([60b23f9](60b23f9))
* Revert "Possible Malware Traffic table search made much more efficient".  It is more efficient, on initial testing, but requires more testing of corner cases.  Reversing the commit until more testing can be done. ([90fae34](90fae34))
github-actions bot pushed a commit that referenced this pull request Jul 24, 2020
## 1.0.0-beta.1 (2020-07-24)

### Features

*  IP Classification and easier field usage.  Fields added:  user, src_class, dst_class, server_ip, server_location, client_ip, client_location.  Note that client_ip was already in use by the config logs and dashboard, so that client_ip field is renamed to admin_ip, and the client_type field is renamed to admin_type.  This is done to avoid naming conflicts. ([f2405cb](f2405cb))
*  New App highlighting.  When apps are added to the master Palo Alto Networks applipedia, Splunk will get the apps and index them.  Then, dashboard panels can be created to show when new apps are added, or if any traffic in the network is matching these new apps. ([550fca6](550fca6))
* Add normalized objects for firewall and Panorama commits ([0983558](0983558)), closes [#220](#220)
* Add support for wildcard address objects ([e859ff6](e859ff6)), closes [#228](#228) [#226](#226)
* Support for Dynamic Address Groups and Dynamic Address Objects (IP address tagging). This feature is utilized similarly to 'panblock', but the command is 'pantag'. ([8753410](8753410))

### Bug Fixes

* config field 'host' overlapped with Splunk default field 'host'.  Changed to 'client_ip'.  Changed 'client' to 'client_type'. ([5bb9a9f](5bb9a9f))
* config field 'host' overlapped with Splunk default field 'host'.  Changed to 'client_ip'.  Changed 'client' to 'client_type'. ([d1f5e76](d1f5e76))
* Correct how target_version is determined ([4269200](4269200)), closes [#216](#216)
* Fix tag-allowed property of VirtualWire ([f02143e](f02143e)), closes [#232](#232) [#221](#221)
* if there are no registered addresses iterator will throw exception ([eabfbd9](eabfbd9))

### Reverts

* Revert "Added a Splunk 6 Data Model to represent the Palo Alto Networks log structure. Currently this model is NOT accelerated due to known Splunk issue (SPL-74415)" ([60b23f9](60b23f9))
* Revert "Possible Malware Traffic table search made much more efficient".  It is more efficient, on initial testing, but requires more testing of corner cases.  Reversing the commit until more testing can be done. ([90fae34](90fae34))
github-actions bot pushed a commit that referenced this pull request Jul 24, 2020
## 1.0.0-beta.1 (2020-07-24)

### Features

*  IP Classification and easier field usage.  Fields added:  user, src_class, dst_class, server_ip, server_location, client_ip, client_location.  Note that client_ip was already in use by the config logs and dashboard, so that client_ip field is renamed to admin_ip, and the client_type field is renamed to admin_type.  This is done to avoid naming conflicts. ([f2405cb](f2405cb))
*  New App highlighting.  When apps are added to the master Palo Alto Networks applipedia, Splunk will get the apps and index them.  Then, dashboard panels can be created to show when new apps are added, or if any traffic in the network is matching these new apps. ([550fca6](550fca6))
* Add normalized objects for firewall and Panorama commits ([0983558](0983558)), closes [#220](#220)
* Add support for wildcard address objects ([e859ff6](e859ff6)), closes [#228](#228) [#226](#226)
* Support for Dynamic Address Groups and Dynamic Address Objects (IP address tagging). This feature is utilized similarly to 'panblock', but the command is 'pantag'. ([8753410](8753410))

### Bug Fixes

* config field 'host' overlapped with Splunk default field 'host'.  Changed to 'client_ip'.  Changed 'client' to 'client_type'. ([5bb9a9f](5bb9a9f))
* config field 'host' overlapped with Splunk default field 'host'.  Changed to 'client_ip'.  Changed 'client' to 'client_type'. ([d1f5e76](d1f5e76))
* Correct how target_version is determined ([4269200](4269200)), closes [#216](#216)
* Fix tag-allowed property of VirtualWire ([f02143e](f02143e)), closes [#232](#232) [#221](#221)
* if there are no registered addresses iterator will throw exception ([eabfbd9](eabfbd9))

### Reverts

* Revert "Added a Splunk 6 Data Model to represent the Palo Alto Networks log structure. Currently this model is NOT accelerated due to known Splunk issue (SPL-74415)" ([60b23f9](60b23f9))
* Revert "Possible Malware Traffic table search made much more efficient".  It is more efficient, on initial testing, but requires more testing of corner cases.  Reversing the commit until more testing can be done. ([90fae34](90fae34))
github-actions bot pushed a commit that referenced this pull request Jul 24, 2020
## 1.0.0-beta.1 (2020-07-24)

### Features

*  IP Classification and easier field usage.  Fields added:  user, src_class, dst_class, server_ip, server_location, client_ip, client_location.  Note that client_ip was already in use by the config logs and dashboard, so that client_ip field is renamed to admin_ip, and the client_type field is renamed to admin_type.  This is done to avoid naming conflicts. ([f2405cb](f2405cb))
*  New App highlighting.  When apps are added to the master Palo Alto Networks applipedia, Splunk will get the apps and index them.  Then, dashboard panels can be created to show when new apps are added, or if any traffic in the network is matching these new apps. ([550fca6](550fca6))
* Add normalized objects for firewall and Panorama commits ([0983558](0983558)), closes [#220](#220)
* Add support for wildcard address objects ([e859ff6](e859ff6)), closes [#228](#228) [#226](#226)
* Support for Dynamic Address Groups and Dynamic Address Objects (IP address tagging). This feature is utilized similarly to 'panblock', but the command is 'pantag'. ([8753410](8753410))

### Bug Fixes

* config field 'host' overlapped with Splunk default field 'host'.  Changed to 'client_ip'.  Changed 'client' to 'client_type'. ([5bb9a9f](5bb9a9f))
* config field 'host' overlapped with Splunk default field 'host'.  Changed to 'client_ip'.  Changed 'client' to 'client_type'. ([d1f5e76](d1f5e76))
* Correct how target_version is determined ([4269200](4269200)), closes [#216](#216)
* Fix tag-allowed property of VirtualWire ([f02143e](f02143e)), closes [#232](#232) [#221](#221)
* if there are no registered addresses iterator will throw exception ([eabfbd9](eabfbd9))

### Reverts

* Revert "Added a Splunk 6 Data Model to represent the Palo Alto Networks log structure. Currently this model is NOT accelerated due to known Splunk issue (SPL-74415)" ([60b23f9](60b23f9))
* Revert "Possible Malware Traffic table search made much more efficient".  It is more efficient, on initial testing, but requires more testing of corner cases.  Reversing the commit until more testing can be done. ([90fae34](90fae34))
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on PyPI and GitHub release

Posted by semantic-release bot

github-actions bot pushed a commit that referenced this pull request Aug 17, 2020
## 1.0.0 (2020-08-17)

### Features

*  IP Classification and easier field usage.  Fields added:  user, src_class, dst_class, server_ip, server_location, client_ip, client_location.  Note that client_ip was already in use by the config logs and dashboard, so that client_ip field is renamed to admin_ip, and the client_type field is renamed to admin_type.  This is done to avoid naming conflicts. ([f2405cb](f2405cb))
*  New App highlighting.  When apps are added to the master Palo Alto Networks applipedia, Splunk will get the apps and index them.  Then, dashboard panels can be created to show when new apps are added, or if any traffic in the network is matching these new apps. ([550fca6](550fca6))
* Add `type` parameter to `CustomUrlCategory` ([f3c85d6](f3c85d6)), closes [#244](#244)
* Add FQDN support to IKE gateways ([722594c](722594c)), closes [#250](#250) [#252](#252)
* Add normalized objects for firewall and Panorama commits ([0983558](0983558)), closes [#220](#220)
* Add support for wildcard address objects ([e859ff6](e859ff6)), closes [#228](#228) [#226](#226)
* Support for Dynamic Address Groups and Dynamic Address Objects (IP address tagging). This feature is utilized similarly to 'panblock', but the command is 'pantag'. ([8753410](8753410))

### Bug Fixes

* config field 'host' overlapped with Splunk default field 'host'.  Changed to 'client_ip'.  Changed 'client' to 'client_type'. ([5bb9a9f](5bb9a9f))
* config field 'host' overlapped with Splunk default field 'host'.  Changed to 'client_ip'.  Changed 'client' to 'client_type'. ([d1f5e76](d1f5e76))
* Correct how target_version is determined ([4269200](4269200)), closes [#216](#216)
* Fix tag-allowed property of VirtualWire ([f02143e](f02143e)), closes [#232](#232) [#221](#221)
* if there are no registered addresses iterator will throw exception ([eabfbd9](eabfbd9))
* Perform release on master branch ([7da85ef](7da85ef))

### Reverts

* Revert "Added a Splunk 6 Data Model to represent the Palo Alto Networks log structure. Currently this model is NOT accelerated due to known Splunk issue (SPL-74415)" ([60b23f9](60b23f9))
* Revert "Possible Malware Traffic table search made much more efficient".  It is more efficient, on initial testing, but requires more testing of corner cases.  Reversing the commit until more testing can be done. ([90fae34](90fae34))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect reference in updater.py logic for current_version.minor
2 participants