Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(panos_ike_crypto_profile): Update DH group choices #461

Merged
merged 1 commit into from
Jul 11, 2023
Merged

fix(panos_ike_crypto_profile): Update DH group choices #461

merged 1 commit into from
Jul 11, 2023

Conversation

jamesholland-uk
Copy link
Member

@jamesholland-uk jamesholland-uk commented Jul 4, 2023 •
edited
Loading

Description

Update DH groups choices for current PAN-OS available options

Motivation and Context

Fixes #460

How Has This Been Tested?

Tested locally

    - name: Add IKE crypto profile
      paloaltonetworks.panos.panos_ike_crypto_profile:
        provider: '{{ device }}'
        state: 'present'
        name: 'ike_profile'
        dh_group: ['group1', 'group2', 'group5', 'group14', 'group15', 'group16', 'group19', 'group20', 'group21']
        authentication: ['sha1']
        encryption: ['aes-128-cbc']
        lifetime_seconds: '28800'

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@jamesholland-uk jamesholland-uk mentioned this pull request Jul 4, 2023
Merged
4 tasks
shinmog
shinmog approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jamesholland-uk jamesholland-uk merged commit 8194318 into develop Jul 11, 2023
@jamesholland-uk jamesholland-uk deleted the update-ike-dh-groups branch July 11, 2023 17:20
github-actions bot pushed a commit that referenced this pull request Jul 11, 2023
@semantic-release-bot
chore(release): 2.17.3
c75fea7 
### [2.17.3](v2.17.2...v2.17.3) (2023-07-11)

### Bug Fixes

* **eda:** Make `custom_logger` argument optional ([#456](#456)) ([49ed307](49ed307))
* **panos_admpwd:** Fix success criteria and update example in docs ([#457](#457)) ([9ecdb65](9ecdb65))
* **panos_bgp_peer_group:** Fix for IBGP export next-hop options ([#459](#459)) ([9489fa2](9489fa2))
* **panos_ike_crypto_profile:** Update DH group choices ([#461](#461)) ([8194318](8194318))
* **panos_ipsec_profile:** Update DH group choices ([#462](#462)) ([1798a3b](1798a3b))
* **panos_software:** Modify valid sequence for downloads only ([#463](#463)) ([214c4bb](214c4bb))
@github-actions
Copy link

🎉 This PR is included in version 2.17.3 🎉

The release is available on Ansible Galaxy and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinmog shinmog shinmog approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panos_ike_crypto_profile doesn't support Diffie-Hellman group 21
2 participants
@jamesholland-uk @shinmog