Improve minimum package error message #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current error message states "panos version < minimum" which infers PAN-OS version on firewall/Panorama. What is really meant is that the pan-os-python package is not at the minimum version.
|
Need to |
|
@shinmog Reformatted dude :-) |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 5, 2021
## [2.9.0](v2.8.0...v2.9.0) (2021-10-05) ### Features * **panos_object_facts:** Add support for Custom URL Categories ([#249](#249)) ([30be003](30be003)) ### Bug Fixes * Improve minimum package error message ([#271](#271)) ([a77a53d](a77a53d)) * **panos_nat_rule:** Correct KeyError for dynamic xlate ([#267](#267)) ([03071b4](03071b4))
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on Ansible Galaxy and GitHub release
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change error message and update comment in code for pandevice/pan-os-python minimum version
Motivation and Context
Current error message states "panos version < minimum" which infers PAN-OS version on firewall/Panorama is below minimum. What is really meant is that the pan-os-python package is not at the minimum version, not the PAN-OS devices.
How Has This Been Tested?
Single string update, tested locally
Types of changes
Checklist