Bugfix panos_nat_rule.py dnat_dynamic_address #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 28, 2021 08:41
… to create_nat_rule() is called
github-actions bot
pushed a commit
that referenced
this pull request
Oct 5, 2021
## [2.9.0](v2.8.0...v2.9.0) (2021-10-05) ### Features * **panos_object_facts:** Add support for Custom URL Categories ([#249](#249)) ([30be003](30be003)) ### Bug Fixes * Improve minimum package error message ([#271](#271)) ([a77a53d](a77a53d)) * **panos_nat_rule:** Correct KeyError for dynamic xlate ([#267](#267)) ([03071b4](03071b4))
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on Ansible Galaxy and GitHub release
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After upgrading to version 2.8.0 my panos_nat_rule no longer worked. I was getting a key error, see below,
Error:
I have corrected this by adding the below to the objects and parsing those params into the function call so create_nat_rule will no longer throw an error when those parameters are not supplied.
Motivation and Context
The change is required because it breaks anything not using the dnat_dynamic_address.
Haven't opened an issue - I wanted to see if I could fix it myself before doing so.
Types of changes
Checklist