-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Polish] Cleanup @ts-ignore usage throughout project #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Size Change: +465 B (0%) Total Size: 2.38 MB
ℹ️ View Unchanged
|
Visit the preview URL for this PR (updated for commit 49fe94b): https://docusaurus-openapi-36b86--pr80-j7swm867.web.app (expires Thu, 09 Jun 2022 14:43:52 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
blindaa121
approved these changes
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change attempts to find and address all instances where
@ts-ignore
was used to ignore typescript issues.Motivation and Context
The goal is to eliminate masking potential issues that typescript would otherwise highlight. Also, this is the first step toward adopting a more strict
tsconfig.js
.How Has This Been Tested?
Screenshots (if appropriate)
Types of changes
Checklist