Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: When language preferences are switched, the warnings for invalid inputs are still showing in English #1579

Closed
Cioppolo14 opened this issue Feb 11, 2024 · 16 comments · Fixed by #2078
Assignees
Labels
bug Something isn't working

Comments

@Cioppolo14
Copy link
Contributor

Cioppolo14 commented Feb 11, 2024

Describe the bug
When the preferred language is not english, warnings (both in top right or below the log in credentials) are not showing in the preferred language. They remain in English.

To Reproduce
Steps to reproduce the behavior:

  1. Set language on login page to any language except English
  2. Attempt to login with bad credentials
  3. Observe the warnings remaining in English

Expected behavior
Once the preferred language is chosen, all the following must be in the preferred language on the admin and user portal pages:

  1. All notifications
  2. All warnings and errors
  3. All text

Screenshots

The following are provided as only one of many other examples of this issue.

Screenshot 2024-02-11 134100

Screenshot 2024-02-11 134133

Additional Details
The location of language translation files is here: /talawa-admin/tree/develop/public/locales

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@Cioppolo14 Cioppolo14 added the bug Something isn't working label Feb 11, 2024
Copy link

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@Sauradip07
Copy link
Contributor

@Cioppolo14 Please assign me this Issue

1 similar comment
@ParishiB
Copy link

@Cioppolo14 Please assign me this Issue

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 22, 2024
@Sauradip07
Copy link
Contributor

I am currently working on this issue please don't unassigned me

@dhruvgupta0503
Copy link

Hi, Is the issue still perssit can I work on this issue pls

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 19, 2024
@Cioppolo14 Cioppolo14 removed the no-issue-activity No issue activity label Mar 19, 2024
@Cioppolo14
Copy link
Contributor Author

Unassigning due to no activity or open PR

@gautam-divyanshu
Copy link
Member

@Cioppolo14 Please assign me this issue

@anuragnegi000
Copy link
Contributor

please assign this issue to me

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 13, 2024
@palisadoes
Copy link
Contributor

Unassigning, inactivity and no submitted PR

@github-actions github-actions bot removed the no-issue-activity No issue activity label Apr 14, 2024
@akhilender-bongirwar
Copy link
Contributor

Please assign this issue to me.

@pranshugupta54
Copy link
Member

I can work on this

@pranshugupta54
Copy link
Member

We need to plan more on fixing this completely. Temporary fix is going to be a very bad practice by checking strings directly. We need either API to send error codes or send translated directly.

Discussion: https://thepalisadoes-dyb6419.slack.com/archives/C01RPC00K0D/p1713875221323299

@pranshugupta54
Copy link
Member

Reference: PalisadoesFoundation/talawa-api#2383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants