Fix golint error #606
Merged
Fix golint error #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
reviewed
Feb 7, 2018
There was a problem hiding this comment.
Need an issue to describe. Is https://github.com/PaddlePaddle/cloud/blob/develop/.travis.yml#L13 this line cause that lint error can still pass on CI?
m3ngyang
reviewed
Feb 7, 2018
| ResourceStateFailed = "failed" | ||
| ResourceStateSucceeded = "succeeded" | ||
| // ResourceStateNone is the none name of ResourceState. | ||
| ResourceStateNone ResourceState = "" |
There was a problem hiding this comment.
ResourceStateNone is the initial state of training job
| // ResourceStateNone is the none name of ResourceState. | ||
| ResourceStateNone ResourceState = "" | ||
| // ResourceStateStarting is the starting name of ResourceState. | ||
| ResourceStateStarting = "starting" |
There was a problem hiding this comment.
ResourceStateStarting is the starting state of training job
| // ResourceStateStarting is the starting name of ResourceState. | ||
| ResourceStateStarting = "starting" | ||
| // ResourceStateRunning is the running name of ResourceState. | ||
| ResourceStateRunning = "running" |
There was a problem hiding this comment.
ResourceStateStarting is the running state of training job
| // ResourceStateRunning is the running name of ResourceState. | ||
| ResourceStateRunning = "running" | ||
| // ResourceStateFailed is the failed name of ResourceState. | ||
| ResourceStateFailed = "failed" |
There was a problem hiding this comment.
ResourceStateFailed is the failed state of training job
| // ResourceStateFailed is the failed name of ResourceState. | ||
| ResourceStateFailed = "failed" | ||
| // ResourceStateSucceeded is the succeeded name of ResourceState | ||
| ResourceStateSucceeded = "succeeded" |
There was a problem hiding this comment.
ResourceStateSucceeded is the succeeded state of training job
|
@typhoonzero I create an ISSUE and fix it yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #609