Cleanup useless gen_config.sh.
#603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compile fails And, need update the unit test if default config is not generated. |
typhoonzero
approved these changes
Feb 8, 2018
| @@ -15,7 +15,7 @@ import ( | |||
| ) | |||
|
|
|||
| // Config is global config object for pfs commandline | |||
| var Config = config.ParseDefaultConfig() | |||
| var Config *config.SubmitConfig | |||
There was a problem hiding this comment.
Why Config global is defined in upload.go, should it be placed in a common file?
There was a problem hiding this comment.
In different packages, they all have Config variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #586