implement registration and listening of crd trainingjob #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m3ngyang
commented
Jan 30, 2018
| trainingjobSynced cache.InformerSynced | ||
|
|
||
| // TODO jobtracker keep track of every training job | ||
| jobtracker map[string]interface{} |
There was a problem hiding this comment.
the interface will be replaced with specific type for managing training job.
m3ngyang
commented
Jan 30, 2018
| if !ok { | ||
| glog.Infof("create a new job tracker, key: '%s'", key) | ||
| glog.Infof("received job: %+v", job) | ||
| // TODO create a tracker for the job, just record its name here |
There was a problem hiding this comment.
TODO create a tracker for the job here
Anyway, can you please split this PR to several small PRs so that I can review. |
|
Thanks for your advice, I will split the pr and submit one by one. |
This was referenced Feb 3, 2018
|
I will split the pr into three parts:
Is this reasonable? @typhoonzero |
This was referenced Feb 4, 2018
|
@m3ngyang Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented a custom resource definition for paddle training job. The changes in this PR include:
go/pkg/controller, responsible for the registration and listening for CRD TrainingJob, and creating a job tracker for each training job to manage its whole lifecyclego/pkg/client, auto generated codes for CRD client and informergo/hack, use our own boilerplate file as default rights comment in generated codesgo/cmd/operator, a new binary component for CRD, which will be combined with the autoscaler in the near featureAbout 1st change, I leave a interface for @qizheng09 to implement the job tracker/controller.