Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix long pending time #470

Merged
merged 7 commits into from
Nov 8, 2017
Merged

Fix long pending time #470

merged 7 commits into from
Nov 8, 2017

Conversation

Yancey1989
Copy link
Collaborator

No description provided.

@Yancey1989 Yancey1989 mentioned this pull request Nov 7, 2017
Closed
typhoonzero
typhoonzero previously approved these changes Nov 8, 2017
View reviewed changes
Copy link
Collaborator

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@Yancey1989
Copy link
Collaborator Author

Hi @typhoonzero , thanks for your review, I fixed the failed unit test, please review this PR again.

@Yancey1989 Yancey1989 mentioned this pull request Nov 8, 2017
Closed
typhoonzero
typhoonzero approved these changes Nov 8, 2017
View reviewed changes
Copy link
Collaborator

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@Yancey1989 Yancey1989 merged commit 27ed9f0 into PaddlePaddle:develop Nov 8, 2017
@Yancey1989 Yancey1989 deleted the fix_long_pending branch November 8, 2017 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typhoonzero typhoonzero typhoonzero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yancey1989 @typhoonzero @helinwang