-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No cross-platform compatibility of logs #244
Comments
The issue seems to be with "std::hashstd::string". The hash method is returning different values on Linux and OSX. binary_record.h:72: So when we read the binary record, we compare the file hash and throw an error if the hash doesn't match: binary_record.h:85: I created a test in "test_binary_record.cc"
And ran test on both Ubuntu and OSX: Ubuntu:
OSX:
@Superjomn I'm not an expert in C++, do you know if there is a more consistant hashing method for cross platform? |
Hash here just works as a filename generator for a So I think a simple but bug-free way is to define a filename generator that does not depend on the content of the record, for example, just a global counter(static) seems work. |
Fixed in #260 |
visualDL has errors when reading logs from another system. For example If logs were generate on linux, and user reads the logs on macOS, the visualDL server will run into alot of errors.
The text was updated successfully, but these errors were encountered: