Add float16 support for pool 2d operator #9167
Merged
+152
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengduoZH
reviewed
Mar 17, 2018
| class TestFP16CUDNN(TestConv2dOp): | ||
| def init_op_type(self): | ||
| self.use_cudnn = True | ||
| self.op_type = "conv2d" |
There was a problem hiding this comment.
self.op_type should be placed in setUp, because the unit tests of test_conv2d_op.py is all about conv2d and the difference is just op_kernels.
There was a problem hiding this comment.
Good point! Done.
| class TestFP16CUDNNCase1(TestPool2d_Op): | ||
| def init_op_type(self): | ||
| self.use_cudnn = True | ||
| self.op_type = "pool2d" |
There was a problem hiding this comment.
The same as the comment above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9166
Our goal is to run vgg/resnet in float16 mode for inference.
pool2d is a necessary operator in those models.