Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a critical bug in softmax_with_cross_entropy_op backward. #9120

Merged
merged 3 commits into from
Mar 15, 2018
Merged

Fix a critical bug in softmax_with_cross_entropy_op backward. #9120

merged 3 commits into from
Mar 15, 2018

Conversation

qingqing01
Copy link
Contributor

Fix #9119

wanghaoshuang
wanghaoshuang approved these changes Mar 15, 2018
View reviewed changes
Copy link
Contributor

@wanghaoshuang wanghaoshuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chengduoZH
chengduoZH approved these changes Mar 15, 2018
View reviewed changes
Copy link
Contributor

@chengduoZH chengduoZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qingqing01 qingqing01 merged commit b5a16dc into PaddlePaddle:develop Mar 15, 2018
@qingqing01 qingqing01 deleted the softmax_with_cross_entropy_op branch March 26, 2018 07:07
@chengduoZH chengduoZH mentioned this pull request Apr 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengduoZH chengduoZH chengduoZH approved these changes

@wanghaoshuang wanghaoshuang wanghaoshuang approved these changes

@lcy-seso lcy-seso Awaiting requested review from lcy-seso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qingqing01 @wanghaoshuang @chengduoZH