Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move float16 into fluid folder #8394

Merged
merged 5 commits into from
Feb 12, 2018

Conversation

kexinzhao
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Feb 12, 2018

CLA assistant check
All committers have signed the CLA.

@wangkuiyi
Copy link
Collaborator

Thanks to @kexinzhao for this PR! It looks good to me!

Just try to confirm, if fluid/platform or fluid/framework a better place than fluid/operators/math directory for FP16?

wangkuiyi
wangkuiyi previously approved these changes Feb 12, 2018
@kexinzhao
Copy link
Contributor Author

Thanks @wangkuiyi for the suggestion!

fluid/framework seems to be a better place, since in framework folder, we have some related files like data_type.h and data_type_transform. float16 is designed to work on both CPU and GPU, so we prefer not to put it in fluid platform folder.

I will modify this pr to put FP16 in fluid/framework.

@kexinzhao
Copy link
Contributor Author

After discussion with @wangkuiyi, we think given that float16 has implementation using CUDA and is thus platform dependent. We prefer to put it in the platform folder.

@kexinzhao kexinzhao merged commit f82fa64 into PaddlePaddle:develop Feb 12, 2018
@kexinzhao kexinzhao deleted the move_float16_to_fluid branch February 12, 2018 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants