Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default build_type env #8019

Merged
merged 2 commits into from
Feb 1, 2018
Merged

Fix default build_type env #8019

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b5588a
Fix default build_type env
Yancey1989 Feb 1, 2018
4db7713
update by comment
Yancey1989 Feb 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions paddle/scripts/docker/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function cmake_gen() {
cat <<EOF
========================================
Configuring cmake in /paddle/build ...
-DCMAKE_BUILD_TYPE=${BUILD_TYPE:Release}
-DCMAKE_BUILD_TYPE=${BUILD_TYPE:-Release}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BUILD_TYPE不需要改成CMAKE_BUILD_TYPE么？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, 确实命名一致比较好。
顺便记录一下CI上PR project也需要做对应修改。

${PYTHON_FLAGS}
-DWITH_DOC=OFF
-DWITH_GPU=${WITH_GPU:-OFF}
Expand All @@ -54,7 +54,7 @@ EOF
# docker environment is fully controlled by this script.
# See /Paddle/CMakeLists.txt, UNITTEST_USE_VIRTUALENV option.
cmake .. \
-DCMAKE_BUILD_TYPE=${BUILD_TYPE:Release} \
-DCMAKE_BUILD_TYPE=${BUILD_TYPE:-Release} \
${PYTHON_FLAGS} \
-DWITH_DOC=OFF \
-DWITH_GPU=${WITH_GPU:-OFF} \
Expand Down