Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dy2St] transforms.RandomCrop Support static mode #49057

Merged
merged 3 commits into from
Dec 16, 2022
Merged

[Dy2St] transforms.RandomCrop Support static mode #49057

merged 3 commits into from
Dec 16, 2022

Conversation

DrRyanHuang
Copy link
Member

PR types

New features

PR changes

OPs

Describe

@paddle-bot
Copy link

paddle-bot bot commented Dec 13, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old paddle-bot-old bot added the contributor External developers label Dec 13, 2022
@SigureMo SigureMo changed the title [Dy2St] transforms.RandomVerticalFlip Support static mode [Dy2St] transforms.RandomCrop Support static mode Dec 14, 2022
@DrRyanHuang
Copy link
Member Author

打扰了,请问 PR-CI-Coverage 中,覆盖了只有 (3 of 5 lines) 60% 的意思是?我不太清楚该从哪个方向修改😸

2022-12-14 22:07:10 Found common filename prefix "/paddle/python/paddle/vision"
2022-12-14 22:07:10 Writing .css and .png files.
2022-12-14 22:07:10 Generating output.
2022-12-14 22:07:10 Processing file transforms/transforms.py
2022-12-14 22:07:10 Writing directory view page.
2022-12-14 22:07:10 Overall coverage rate:
2022-12-14 22:07:10   lines......: 60.0% (3 of 5 lines)
2022-12-14 22:07:10 + echo 'Assert Diff Coverage'
2022-12-14 22:07:10 Assert Diff Coverage
2022-12-14 22:07:10 + python3.7 /paddle/tools/coverage/coverage_lines.py coverage-diff.info 0.9
2022-12-14 22:07:10 no data found
2022-12-14 22:07:10 + echo 'Assert Python Diff Coverage'
2022-12-14 22:07:10 Assert Python Diff Coverage

@SigureMo
Copy link
Member

打扰了,请问 PR-CI-Coverage 中,覆盖了只有 (3 of 5 lines) 60% 的意思是?我不太清楚该从哪个方向修改😸

image

python-coverage 选项卡有详情,看起来貌似是静态图分支没有覆盖?(虽然没有看出来为啥没有被覆盖)

@DrRyanHuang
Copy link
Member Author

我本地测试了一下,应该是覆盖的 😆
image

2022-12-14 22:07:06 + python3.7 /paddle/tools/coverage/pull_request.py diff 49057
2022-12-14 22:07:10 + lcov --extract python-coverage-full.info /paddle/python/paddle/tests/test_transforms_static.py /paddle/python/paddle/vision/transforms/transforms.py -o python-coverage-diff.info --rc lcov_branch_coverage=0
2022-12-14 22:07:10 Reading tracefile python-coverage-full.info
2022-12-14 22:07:10 Extracting /paddle/python/paddle/vision/transforms/transforms.py
2022-12-14 22:07:10 Extracted 1 files
2022-12-14 22:07:10 Writing data to python-coverage-diff.info
2022-12-14 22:07:10 Summary coverage rate:
2022-12-14 22:07:10   lines......: 94.0% (457 of 486 lines)
2022-12-14 22:07:10   functions..: no data found
2022-12-14 22:07:10   branches...: no data found
2022-12-14 22:07:10 + python3.7 /paddle/tools/coverage/coverage_diff.py python-coverage-diff.info python-git-diff.out
2022-12-14 22:07:10 + mv -f python-coverage-diff.tmp python-coverage-diff.info
2022-12-14 22:07:10 + genhtml -o python-coverage-diff -t 'Python Diff Coverage' --no-function-coverage --no-branch-coverage --ignore-errors source python-coverage-diff.info
2022-12-14 22:07:10 Reading data file python-coverage-diff.info
2022-12-14 22:07:10 Found 1 entries.
2022-12-14 22:07:10 Found common filename prefix "/paddle/python/paddle/vision"
2022-12-14 22:07:10 Writing .css and .png files.
2022-12-14 22:07:10 Generating output.
2022-12-14 22:07:10 Processing file transforms/transforms.py
2022-12-14 22:07:10 Writing directory view page.
2022-12-14 22:07:10 Overall coverage rate:
2022-12-14 22:07:10   lines......: 60.0% (3 of 5 lines)
2022-12-14 22:07:10 + echo 'Assert Diff Coverage'

感觉像是 /paddle/tools/coverage/coverage_diff.py 把静态图分支给判定没了

Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 merged commit a057625 into PaddlePaddle:develop Dec 16, 2022
@DrRyanHuang DrRyanHuang deleted the RandomResizedCrop branch December 16, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants