Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make save_model support non-fault-tolerant paddle cloud training #3624

Closed
wants to merge 1 commit into from

Conversation

helinwang
Copy link
Contributor

@helinwang helinwang commented Aug 22, 2017

Fixes: #3625

# error
return
trainer_id = os.environ.get(trainer_key)
etcd_key = "ETCD_IP"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious where to set ETCD_IP env?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I see.

# do not need to save
return
elif r < 0:
# error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log or print to stderr?

@@ -33,37 +30,38 @@ def mkdir_p(path):
raise


def save_model(parameters, path):
def save_model(parameters, folder, name="model.tar"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add doc string?

@helinwang
Copy link
Contributor Author

This PR is out-of-date, closing.

@helinwang helinwang closed this Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants