add replace enforce with glog switch for debug #11244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superjomn
changed the title
|
Please run with gdb and enforce and see if we can also see the message with line number. |
|
We can get the line message if we have the core dump file. Only we use root or docker to generate this file. |
|
Run the program in gdb with exception cannot get any call stack calling |
Superjomn
changed the title
gongweibao
requested changes
Jun 30, 2018
| @@ -131,6 +132,10 @@ if (NOT DEFINED WITH_MKLDNN) | |||
| set(WITH_MKLDNN OFF) | |||
| endif() | |||
| endif() | |||
|
|
|||
| if (REPLACE_ENFORCE_GLOG) | |||
There was a problem hiding this comment.
put into configure.cmake?
| @@ -212,6 +238,9 @@ inline void throw_on_error(T e) { | |||
| __FILE__, __LINE__); \ | |||
| } \ | |||
| } while (false) | |||
| #else | |||
| #define PADDLE_ENFORCE(...) ::paddle::platform::throw_on_error(__VA_ARGS__); | |||
| @@ -84,7 +84,7 @@ void Fprintf(std::ostream& out, const char* fmt, const Args&... args) { | |||
| } | |||
|
|
|||
| template <typename... Args> | |||
| std::string Sprintf(const char* fmt, const Args&... args) { | |||
| std::string Sprintf(const char* fmt = "", const Args&... args) { | |||
gongweibao
approved these changes
Jun 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
PADDLE_ENFORCE's exceptionGLOG error:
with gdb, there is
The more clear error stack with line number is provided, easier for debugging.