Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on the cmake flag WITH_DISTRIBUTE on CI system #9046

Closed
Yancey1989 opened this issue Mar 14, 2018 · 8 comments
Closed

Turn on the cmake flag WITH_DISTRIBUTE on CI system #9046

Yancey1989 opened this issue Mar 14, 2018 · 8 comments
Assignees

Comments

@Yancey1989
Copy link
Contributor

Yancey1989 commented Mar 14, 2018

it's better to cache the third-party package on CI so that we can improve CI performance and turn on WITH_DISTRIBUTE cmake flag as also.

We can't turn on WITH_DISTRIBUTE currently is just because building gRPC dependency would task very very long time.

@Yancey1989
Copy link
Contributor Author

Yancey1989 commented Mar 22, 2018

We can not turn on the cmake flag WITH_DISTRIBUTE=ON utile the following bug fixed:

@Yancey1989 Yancey1989 changed the title Cache thirdparty package on CI Turn on the cmake flag WITH_DISTRIBUTE on CI system Mar 22, 2018
@helinwang
Copy link
Contributor

@Yancey1989 can you @ yourself on the ones you are working on? I will work on the not taken ones tomorrow.

@gongweibao
Copy link
Contributor

gongweibao commented Mar 22, 2018

Another two:

@Yancey1989
Copy link
Contributor Author

Yancey1989 commented Mar 22, 2018

Thanks @helinwang, I'll take #9292 : )

@helinwang
Copy link
Contributor

@putcn would love some help here in case you have bandwidth :D

@putcn
Copy link
Contributor

putcn commented Mar 27, 2018

I can work on #9309

@typhoonzero
Copy link
Contributor

@Yancey1989 @putcn Can we close this now?

@Yancey1989
Copy link
Contributor Author

Okay, will close this issue, we already turn on the cmake flag WITH_DISTRIBUTE=ON on the CI system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants