-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the document for norm op #7266
Comments
And the name of this op is not very good because it is too general. "cross_channel_norm" might be better |
Actually, I think a general norm operator is better and this general norm operator can support to do norm in any dimension. A long time ago, @guoshengCS had implemented a general norm operator, And I think a general norm operator can support |
We need such a general purpose norm operator in the NMT task. A related issue is #7350 . I will discuss with @qingqing01 later to fix this problem. |
Because we need a general purpose norm operator. Currently, I am working on this. |
Here is the doc
The text was updated successfully, but these errors were encountered: