Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the document for norm op #7266

Closed
emailweixu opened this issue Jan 6, 2018 · 4 comments
Closed

Fix the document for norm op #7266

emailweixu opened this issue Jan 6, 2018 · 4 comments
Assignees

Comments

@emailweixu
Copy link
Collaborator

Here is the doc

@emailweixu
Copy link
Collaborator Author

And the name of this op is not very good because it is too general. "cross_channel_norm" might be better

@qingqing01
Copy link
Contributor

qingqing01 commented Jan 8, 2018

Actually, I think a general norm operator is better and this general norm operator can support to do norm in any dimension. A long time ago, @guoshengCS had implemented a general norm operator,
#4496 . This PR used abs_op, reduce_sum_op and pow_op to combine a norm operator in C++ code. But when the net_op was removed, this norm_op was deleted.

And I think a general norm operator can support cross_channel_norm_op, when @sweetsky0901 planed to implement to cross_channel_norm_op, I discussed with her, we should implement a general norm operator.

@lcy-seso
Copy link
Contributor

lcy-seso commented Jan 9, 2018

We need such a general purpose norm operator in the NMT task. A related issue is #7350 . I will discuss with @qingqing01 later to fix this problem.

@lcy-seso
Copy link
Contributor

Because we need a general purpose norm operator. Currently, I am working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants