Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of pickle for Storing format of inference #7221

Closed
kexinzhao opened this issue Jan 4, 2018 · 2 comments · Fixed by #7712
Closed

Get rid of pickle for Storing format of inference #7221

kexinzhao opened this issue Jan 4, 2018 · 2 comments · Fixed by #7712
Assignees
@abhinavarora @kavyasrinet @kexinzhao
Labels
预测 原名Inference，包含Capi预测问题等

Comments

@kexinzhao
Copy link
Contributor

kexinzhao commented Jan 4, 2018 •
edited
Loading

Currently Pickle is used in fluid.io.save_inference_model to save inference protobuf string and feed and fetch var names.

However it is not well supported for the c++ side to parse the serializing format provided by pickle.

To make the inference API concise, we need to get rid of pickle.
@kexinzhao kexinzhao self-assigned this Jan 4, 2018
@Xreki Xreki mentioned this issue Jan 4, 2018
Closed
@kavyasrinet kavyasrinet self-assigned this Jan 4, 2018
@abhinavarora abhinavarora self-assigned this Jan 4, 2018
@kavyasrinet kavyasrinet mentioned this issue Jan 5, 2018
Closed
@Xreki Xreki added the 预测 原名Inference，包含Capi预测问题等 label Jan 5, 2018
@sidgoyal78 sidgoyal78 mentioned this issue Jan 6, 2018
Merged
@abhinavarora
Copy link
Contributor

One strategy that I am exploring right now is to create a new ProtoBuf called InferenceDesc that can incorporate the ProgramDesc and Model Params. This is a related issue for that #7328

@kavyasrinet
Copy link

I added a proposal in the same issue to avoid duplication, since I started working on the same issue (#7328) as well. @abhinavarora and I can work together on this I guess.

@kexinzhao kexinzhao mentioned this issue Jan 9, 2018
Closed
@kexinzhao kexinzhao mentioned this issue Jan 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhinavarora abhinavarora

@kavyasrinet kavyasrinet

@kexinzhao kexinzhao

Labels
预测 原名Inference，包含Capi预测问题等
Projects
None yet
Milestone
No milestone
4 participants
@abhinavarora @kavyasrinet @kexinzhao @Xreki