From b15c8508b1581cb0a160dd7adbe5f12a6189770d Mon Sep 17 00:00:00 2001 From: Alexander Blanchard Date: Wed, 12 Jun 2024 11:25:23 +0100 Subject: [PATCH 1/3] fix: summon results filtering fix Adjust code so that if not on page one of results when a filter is applied, the new results set begins on page one. Fix bug: if current result numerical value is greater than the number of results available in a facet filter, the facet filter did not apply when clicked. --- code/web/sys/SearchObject/SummonSearcher.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/web/sys/SearchObject/SummonSearcher.php b/code/web/sys/SearchObject/SummonSearcher.php index 4f024dd4dc..18c34d6fd6 100644 --- a/code/web/sys/SearchObject/SummonSearcher.php +++ b/code/web/sys/SearchObject/SummonSearcher.php @@ -496,7 +496,7 @@ public function getFacetSet() { if ($isApplied) { $facetSettings['removalUrl'] = $this->renderLinkWithoutFilter($facetId . ':' . $facetValue); } else { - $facetSettings['url'] = $this->renderSearchUrl() . '&filter[]=' . $facetId . ':' . urlencode($facetValue); + $facetSettings['url'] = $this->renderSearchUrl() . '&filter[]=' . $facetId . ':' . urlencode($facetValue) . '&page=1'; } $list[] = $facetSettings; } From 1f97069da736a335135f726f7be88c6350061c7c Mon Sep 17 00:00:00 2001 From: Alexander Blanchard Date: Fri, 12 Jul 2024 12:58:37 +0100 Subject: [PATCH 2/3] chore: Update change log --- code/web/release_notes/24.07.00.MD | 1 + 1 file changed, 1 insertion(+) diff --git a/code/web/release_notes/24.07.00.MD b/code/web/release_notes/24.07.00.MD index ee846ccf9e..fcfeda17e9 100644 --- a/code/web/release_notes/24.07.00.MD +++ b/code/web/release_notes/24.07.00.MD @@ -76,6 +76,7 @@ ### Summon Updates - Adjustments to code in Summon getFacetSet function to correct a bug. Individual facet filters can now be unchecked and the filter unset by clicking the checkbox. (*AB*) +- Adjust code to ensure that the filter applies correctly no matter what page of results users are on when they apply it. (*AB*) ### Other Updates - Show the original translation term when translating text within Aspen. (*MDN*) From 125cc9efb9a18d5863ca5e5b48f6cd302b5d755e Mon Sep 17 00:00:00 2001 From: Alexander Blanchard Date: Wed, 17 Jul 2024 11:33:37 +0100 Subject: [PATCH 3/3] chore: update correct MD file and rebase --- code/web/release_notes/24.07.00.MD | 1 - code/web/release_notes/24.08.00.MD | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/code/web/release_notes/24.07.00.MD b/code/web/release_notes/24.07.00.MD index fcfeda17e9..ee846ccf9e 100644 --- a/code/web/release_notes/24.07.00.MD +++ b/code/web/release_notes/24.07.00.MD @@ -76,7 +76,6 @@ ### Summon Updates - Adjustments to code in Summon getFacetSet function to correct a bug. Individual facet filters can now be unchecked and the filter unset by clicking the checkbox. (*AB*) -- Adjust code to ensure that the filter applies correctly no matter what page of results users are on when they apply it. (*AB*) ### Other Updates - Show the original translation term when translating text within Aspen. (*MDN*) diff --git a/code/web/release_notes/24.08.00.MD b/code/web/release_notes/24.08.00.MD index ebe9e23da9..f03f1f5517 100644 --- a/code/web/release_notes/24.08.00.MD +++ b/code/web/release_notes/24.08.00.MD @@ -18,6 +18,8 @@ - Fixed bug with unexpected 404 errors on Web Builder pages. (Ticket 123122) (*KP*) // alexander +### Summon Updates +- Adjust code to ensure that the filter applies correctly no matter what page of results users are on when they apply it. (*AB*) // jacob