Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.9.0 #1417

Closed
MattHJensen opened this issue Jun 8, 2017 · 5 comments
Closed

Release 0.9.0 #1417

MattHJensen opened this issue Jun 8, 2017 · 5 comments

Comments

@MattHJensen
Copy link
Contributor

MattHJensen commented Jun 8, 2017

In major pull requests, please add a commit that edits the 0.9.0 section of the release history.

The last commit in 0.8.5 was fddde79, which was the merge of #1416 on June 8, 2017.

Before releasing 0.9.0, I need to add a commit that

  • updates the date of the 0.9.0 release in RELEASES.md
  • updates the last PR#
@martinholmer martinholmer changed the title Release 0.8.6 Release 0.9.0 Jun 12, 2017
@MattHJensen
Copy link
Contributor Author

@martinholmer, did you change the title name because you know there are API breaking changes in this particular upcoming release or because you think our default position should be to assume that each new release will be major?

My preference is that we should assume the next release will be minor until we have evidence that it will be major (a PR with API breaking changes), and then we can leave a comment on this issue stating that it will be major and update the title name and the filler release title in RELEASES.md at that time. The primary reason for suggesting this is that in some cases we may want to have a discussion about whether the backwards incompatible commits should be included in the forthcoming release or a future one. That said, I also understand the position that we should assume each new release is major until we hit 1.0.0, and then after 1.0.0 assume each new release is going to be minor.

@martinholmer
Copy link
Collaborator

@MattHJensen asked:

did you change the title name because you know there are API breaking changes in this particular upcoming release or because you think our default position should be to assume that each new release will be major?

Pull request #1424 (which I expect to merge today) changes the public API, and so do some of the other merged pull requests mentioned in #1424. None of element removed from the public API were being used by client projects (as far as I can tell). But these changes are still changes in the public API.

@MattHJensen
Copy link
Contributor Author

@MattHJensen
Copy link
Contributor Author

@andersonfrailey @martinholmer @hdoupe @econ02

taxcalc 0.9.0 is now on the test app. (http://ospc-taxes7.herokuapp.com/taxbrain/). If you have an opportunity, could you check to see if your enhancements since 0.8.3 are working properly on TaxBrain?

@MattHJensen
Copy link
Contributor Author

Currently getting an error on simulations. I will give you an update when it is worth trying to test again. Sorry for the false start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants