From ba9a15bc2a18474cc5ffaaa34795fdf380e20a64 Mon Sep 17 00:00:00 2001 From: Ignacio Vizzo Date: Fri, 1 Mar 2024 10:39:45 +0100 Subject: [PATCH 1/2] Prepend `kiss_icp_` for env variable usage Before this didn't work ``` export DATA=carlos kiss_icp_pipeline ... ``` After, you need to be more explicit to break it: ``` export KISS_ICP_DATA=carlos kiss_icp_pipeline ... ``` This allow us to mantain the API as well --- python/kiss_icp/config/parser.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/python/kiss_icp/config/parser.py b/python/kiss_icp/config/parser.py index 5f2b58ec..831f3039 100644 --- a/python/kiss_icp/config/parser.py +++ b/python/kiss_icp/config/parser.py @@ -28,12 +28,13 @@ from pathlib import Path from typing import Any, Dict, Optional -from pydantic_settings import BaseSettings +from pydantic_settings import BaseSettings, SettingsConfigDict from kiss_icp.config.config import AdaptiveThresholdConfig, DataConfig, MappingConfig class KISSConfig(BaseSettings): + model_config = SettingsConfigDict(env_prefix="kiss_icp_") out_dir: str = "results" data: DataConfig = DataConfig() mapping: MappingConfig = MappingConfig() From ba8f2435ed7891ff0d108f455ad1d138d0e0a922 Mon Sep 17 00:00:00 2001 From: Benedikt Mersch Date: Fri, 1 Mar 2024 10:59:16 +0100 Subject: [PATCH 2/2] Add to help --- python/kiss_icp/tools/cmd.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/python/kiss_icp/tools/cmd.py b/python/kiss_icp/tools/cmd.py index 87f94bd9..5ae7369e 100644 --- a/python/kiss_icp/tools/cmd.py +++ b/python/kiss_icp/tools/cmd.py @@ -114,6 +114,10 @@ def name_callback(value: str): # Use a more specific dataloader: {", ".join(_available_dl_help)} $ kiss_icp_pipeline --dataloader kitti --sequence 07 --visualize :open_file_folder: + +# To change single config parameters on-the-fly, you can export them beforehand: +$ export kiss_icp_out_dir=':open_file_folder:' +$ export kiss_icp_data='{{"max_range": 50}}' """