Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write internal text handling routines #3

Closed
PMunch opened this issue Jun 6, 2018 · 1 comment
Closed

Write internal text handling routines #3

PMunch opened this issue Jun 6, 2018 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@PMunch
Copy link
Owner

PMunch commented Jun 6, 2018

The LSP specification says that all code will be transported over UTF-8 in a JSON object. However it sends position as the UTF-16 representation. Yes this is dumb, but while it stays this way we must conform to it. So if anyone could do an internal text representation module that supports the TextEdit specification from the spec it would be really helpful for when we can start implementing the actual functionality.
@PMunch PMunch added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 6, 2018
@PMunch
Copy link
Owner Author

PMunch commented Nov 4, 2018

This was more or less done in https://github.com/PMunch/nimlsp/blob/master/src/nimlsppkg/utfmapping.nim. It doesn't support updating the finger table based on incremental changes, so currently the entire file is requested for the didChange requests.

@PMunch PMunch closed this as completed Dec 11, 2018
@PMunch PMunch mentioned this issue Sep 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PMunch