Issue 112 jackknife #113
Merged
Issue 112 jackknife #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e jackknife variance estimator.
…knife and variance_bootsrap)
…`PLN()`, based on problems reported in #112.
…t-treatment functions).
- bump version number
jchiquet
reviewed
Nov 17, 2023
R/PLNfit-class.R
Outdated
| @@ -205,13 +209,17 @@ PLNfit <- R6Class( | |||
| }, | |||
|
|
|||
| variance_jackknife = function(Y, X, O, w, config = config_default_nlopt) { | |||
| cat("\n Computing jackknife variance estimator", sep = "\n") | |||
There was a problem hiding this comment.
Could you add a condition to display the message (based on the config argument) ??
There was a problem hiding this comment.
Argh, this a leftover from my debugging session. I'm inclined to remove it completely. Do you think we should keep it (if so, I'll add the condition and do the same for bootstrap) ?
…cking the package.
jchiquet
reviewed
Nov 17, 2023
There was a problem hiding this comment.
Thanks, you should also add an entry into the _pkgdown.yml file to avoid the corresponding action to fail.
For instance, here :
https://github.com/PLN-team/PLNmodels/blob/2657e506675ad26e77df94f9c40f02ae11aa1042/_pkgdown.yml#L110C39-L110C39
(and you could remove one of the redundant 'rPLN' entry by the way...)
jchiquet
approved these changes
Nov 17, 2023
jchiquet
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #112 by
Jackknife and bootstrap variance / sd estimators returned with
standard_error(myPLN, "bootstrap")orstandard_error(myPLN, "jackknife")are now identical to the ones computed "manally" with repeated call toPLN()For @jchiquet, you can ignore all commits made before [df51164] / 17th of November, they have been reverted back in further commits.