Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] transcript 功能在 New Window 没有生效 #359

Closed
bcdax110 opened this issue May 12, 2024 · 4 comments
Closed

[Bug] transcript 功能在 New Window 没有生效 #359

bcdax110 opened this issue May 12, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@bcdax110
Copy link

bcdax110 commented May 12, 2024

在视频链接默认行为 New Window 模式下,播放器右下角的字幕选择按钮、播放器右上角更多选项的Open transcript 没有出现

注:

  • 我试过链接默认行为是“New pane on the right“、“New pane on the bottom“、“New tab“、“In current pane“的时候是没有问题的,transcript 功能是可以出现的。
  • 在tab模式(即除了New Window)下,拖拽播放器标签成新的窗口,字幕相关控件是正常出现的,但是功能不一定是正常的
    • 如果先打开字幕后,后把播放器拖拽成新窗口:能正常使用
    • 如果先把播放器拖拽成新窗口,再尝试打开字幕:从右上角打开字幕时,提示Failed to save transcript: track 一串数字 not found,如果把拖拽出来的新窗口拖拽回tab,就和“如果先打开字幕后,后把播放器拖拽成新窗口”的情况类似是可以正常使用的
@aidenlx
Copy link
Member

aidenlx commented May 13, 2024

你具体是在哪种类型的视频和字幕上有这个问题的?能建个可以复现的新库吗?我这边没有复现出来

@bcdax110
Copy link
Author

我在沙盒仓库只安装Media Extended的情况下试了一下,用插件登录了b站账号。从b站主页随便选的视频(都是在b站的播放器上有字幕选项的),不论视频是否分p,字幕是否是自动生成的,在New Window模式都没有对应按钮出来

@aidenlx aidenlx added the bug Something isn't working label May 13, 2024
@aidenlx
Copy link
Member

aidenlx commented May 13, 2024

确认是哪里的问题了,我看下下个版本应该可以修复

@bcdax110
Copy link
Author

我看到这个问题已经在提交中改掉了,是否方便先把这个改变发个版,我试着从dev直接构建结果没成功

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants