Building with MSVC

[kyursen]

Is it fine for libcbor to be buildable with MSVC (at least with VS 2013)?

It is possible, but the cost is losing the C99 compliance:

1. Replace C99 restrict keyword with MSVC-specific __restrict.
2. The same is with inline - replace it with __inline.

These two replacements can be made via CMakeLists:

if(MSVC)
    set(CBOR_RESTRICT "__restrict")
    set(CBOR_INLINE "__inline")
else()
    set(CBOR_RESTRICT "restrict")
    set(CBOR_INLINE "inline")
endif()

3. #include <stdlib.h> instead of #include <unistd.h>.
4. Add const parameter qualifier to cbor_new_definite_map/array implementations (typo?).

[kyursen]

I may prepare a PR from a test branch https://github.com/kyursen/libcbor/tree/msvc (after some cleanups)

[PJK]

Is it fine for libcbor to be buildable with MSVC (at least with VS 2013)?

Of course

Thank you for your suggestions, I've implemented most of them #47. inline and restrict didn't work as expected (in particular I don't understand why __inline in the source file makes the symbols disappear: https://ci.appveyor.com/project/PJK/libcbor/build/15, I plan on removing it anyway), but those are not fundamental limitations.

[kyursen]

Thank you!