Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Rotation with HTML Reader #235

Closed
1 of 3 tasks
bfeduclever opened this issue Sep 29, 2017 · 11 comments
Closed
1 of 3 tasks

Text Rotation with HTML Reader #235

bfeduclever opened this issue Sep 29, 2017 · 11 comments

Comments

@bfeduclever
Copy link

bfeduclever commented Sep 29, 2017

This is:

What is the expected behavior?

Have the text vertically from an attribute of a td

<td alignment-textRotation="90">

What is the current behavior?

The rotation is not done

Which versions of PhpSpreadsheet and PHP are affected?

The current version : 1.0.0-beta

@yasar-luo
Copy link
Contributor

can you describe what does this attribute do?
in excel, which function does it refer to?

@PowerKiKi
Copy link
Member

HTML writer and reader don't support text orientation, and if they did they would have to do so via standard CSS rules, such as style="transform: rotate(-90deg);", not proprietary attributes like alignment-textRotation="90". Would you like to submit a patch for that ?

@yasar-luo
Copy link
Contributor

I'll add the new function later.

@yasar-luo
Copy link
Contributor

@menthol
Copy link

menthol commented Oct 1, 2017

Hello @GreatHumorist , I work with @bfeduclever.

What we want is basically to have the ability to rotate a entire text in a cell (the second link).

In HTML and CSS they can be implemented as :

<p class="vertical-rl-upright">vertical-rl-upright</p>
<p class="vertical-lr-upright">vertical-lr-upright</p>
<p class="rotation-90">rotation-90</p>
<p class="rotation-45">rotation-45</p>
<p class="rotation45">rotation45</p>
<p class="rotation90">rotation90</p>
.vertical-rl-upright {writing-mode: vertical-rl; text-orientation: upright;}
.vertical-lr-upright {writing-mode: vertical-lr; text-orientation: upright;}
.rotation-90 {transform: rotate(-90deg);}
.rotation-45 {transform: rotate(-45deg);}
.rotation45 {transform: rotate(45deg);}
.rotation90 {transform: rotate(90deg);}

@bfeduclever
Copy link
Author

Hello @GreatHumorist ,

Here a working html exemple : https://codepen.io/anon/pen/EwvRJX

Best regards

@stale
Copy link

stale bot commented Dec 4, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

@stale stale bot added the stale label Dec 4, 2017
@bfeduclever
Copy link
Author

Too bad the request was interesting for us :(

@stale stale bot removed the stale label Dec 4, 2017
@stale
Copy link

stale bot commented Feb 2, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

@stale stale bot added the stale label Feb 2, 2018
@stale stale bot closed this as completed Feb 9, 2018
@oleibman
Copy link
Collaborator

Html text rotation was added by PR #2960 in July 2022.

@yasar-luo
Copy link
Contributor

yasar-luo commented Jul 11, 2024 via email

@oleibman oleibman removed the stale label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants