Writer\Html output is much too large

[werbfred]

This is:

- [ ] a bug report
- [x ] a feature request
- [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

What is the expected behavior?

When using the save method from PhpOffice\PhpSpreadsheet\Writer\Html, we could expect that only the usefull data is being outputed. This works fine for PhpOffice\PhpSpreadsheet\Writer\Csv.

What is the current behavior?

Currently PhpOffice\PhpSpreadsheet\Writer\Html uses the method Worksheet::calculateWorksheetDimension() which is relying on Worksheet::getHighestColumn().

In this case it could be better to rely on Worksheet::getHighestDataColumn(). This would avoid displaying a lot of empty cells on the right side of the html table. HTML file would also be much smaller.

What are the steps to reproduce?

Call PhpOffice\PhpSpreadsheet\Writer\Html::save() and have the generated file rendered in your favortie web browser.

Which versions of PhpSpreadsheet and PHP are affected?

Php version 7.3
PhpSpreadsheet version 1.9

[werbfred]

Looking at the source code I would suggest that in Html::generateSheetData() the line

$dimension = explode(':', $sheet->calculateWorksheetDimension());

should be replaced by

$dimension = explode(':', $sheet->calculateWorksheetDataDimension());

That would do the job I believe.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

[werbfred]

Any feedback if this feature make sense ?

[adjenks]

Only the stale bot is responding to my tickets as well.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

[werbfred]

Up

[PowerKiKi]

I guess it makes sense. Have any of you had a look a git blame to see if there is a reason why we don't already do that?

[werbfred]

Should I make a Pull Request ?

[werbfred]

Pull Request raised : Writer\Html output is much too large #1537