Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic config option: allowRisky #16

Open
jrfnl opened this issue Jul 17, 2018 · 0 comments
Open

Generic config option: allowRisky #16

jrfnl opened this issue Jul 17, 2018 · 0 comments
Labels
enhancement meta Repo strategy/structure related

Comments

@jrfnl
Copy link
Member

jrfnl commented Jul 17, 2018

Add a generic config option allowRisky which defaults to false.

This option should be respected by all sniffs which do something which could be considered risky, i.e. might cause parse errors or unit tests to fail as the code change is more involved.

The option could be set using either --runtime-set allowRisky true or by adding <config name"allowRisky" value="true"/> to a custom ruleset.

Levels of riskiness

Alternatively, based on the same principle, a granularization could be added using numeric riskiness levels

My current line of thinking would be:

  • 0 being non-risky;
  • 1 being a little risky, but will probably be OK;
  • 2 code will always need manual review after the fixer has run;
  • 3 possibility of parse error being introduced.

Opinions welcome!

@jrfnl jrfnl added enhancement meta Repo strategy/structure related labels Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement meta Repo strategy/structure related
Projects
None yet
Development

No branches or pull requests

1 participant