Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CHANGELOG.md #17

Closed
frenck opened this issue Feb 17, 2017 · 7 comments
Closed

Add a CHANGELOG.md #17

frenck opened this issue Feb 17, 2017 · 7 comments
Assignees
Milestone

Comments

@frenck
Copy link
Contributor

frenck commented Feb 17, 2017

Problem/Motivation

To make it easier for users and contributors to see precisely what notable changes have been made between each release (or version) of the project, a changlog should be added.

Expected behaviour / Actual behaviour / Steps to reproduce

Does not apply

Proposed changes

Add a changelog file to the root of this repository, using the format specified in the Keep a CHANGELOG documentation.

@frenck frenck added this to the v1.0.0 milestone Feb 17, 2017
@frenck frenck self-assigned this Feb 17, 2017
@Potherca
Copy link
Member

I've been using skywinder/Github-Changelog-Generator and at first sight it looks good.

There might be some minor points for improvement, but I'm sure we could open some PRs (or maintain a corporate fork) to tweak it for our own use...

@Wirone
Copy link

Wirone commented May 9, 2017

Guys, do you know http://keepachangelog.com/ ?

@Potherca
Copy link
Member

Potherca commented May 9, 2017

Yes, we do 😸 (Franck even links to it in his issue description).

skywinder/Github-Changelog-Generator is keepachangelog.com compatible.

@frenck
Copy link
Contributor Author

frenck commented May 9, 2017

We currently already use the output of it in the GitHub releases descriptions of this repository.

https://github.com/DealerDirect/phpcodesniffer-composer-installer/releases

@Wirone
Copy link

Wirone commented May 9, 2017

@Potherca Oh, I missed that part in description (shame on me). I must check skywinder/Github-Changelog-Generator in that case :-)

@frenck
Copy link
Contributor Author

frenck commented May 10, 2017

I've discussed this today with @Potherca and @brammittendorff-dd in person.

Some time ago we already started keeping a change log between releases in the GitHub releases section of this repository.

Keeping a second change log inside the repo seems duplicate and causes extra overhead in the review process. Secondly; the GitHub releases interface, combined with change logs we place there, gives a much easier en feature rich way to analyse thinks, since you can click on everything.

We do agree we should tell people where to find the change logs, so we will be adding documentation and links in the README.

@frenck frenck modified the milestones: v0.4.0, v1.0.0 May 11, 2017
@frenck
Copy link
Contributor Author

frenck commented May 11, 2017

Added references to the changelogs in #31. Closing this issue.

@frenck frenck closed this as completed May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants