-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Symfony.trailing_comma_in_multiline - adjust configuration #8161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New option has been added so this PR might need updating.
Maybe:
'trailing_comma_in_multiline' => [
'after_heredoc' => true,
'elements' => [ // explicitly omit 'arguments'
'array_destructuring',
'arrays',
'match',
'parameters',
],
],
thanks @SpacePossum for |
Are we supposed to run php-cs-fixer on the minimum supported PHP version in a project? What am I supposed to do for a library that still supports PHP 7.4, but my local installation of PHP is 8.3? |
@spawnia if your library still supports PHP 7.4, as PHP CS Fixer itself, you need to go with only PHP 7.4 options, as PHP CS Fixer itself does: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.64.0/src/RuleSet/Sets/PhpCsFixerSet.php#L123 |
I see, so there is no version detection magic going on. We are extending the Symfony config, which explains why this change broke our project. Thank you for the response. |
No, there is no such detection, might happen in the future, there is a discussion about this: #7312. |
haha, another case how to handle config configuration that is dependent on PHP version