-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing in pull requests #12
Open
JanosJiri
wants to merge
17
commits into
master
Choose a base branch
from
testing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
f6b630d
Small modification for README and .gitignore
JanosJiri f2ce5eb
creating ci.yml
JanosJiri 403d67b
Make in src
JanosJiri fcaec60
Try FFTW
JanosJiri 61a541a
New test
JanosJiri be5b8ba
Testing
JanosJiri 2503c0f
testing 2
JanosJiri 798f607
testing 3
JanosJiri 698cbf8
testing 4
JanosJiri 30d4258
testing 5
JanosJiri 0ce8740
testing 6
JanosJiri 80c2051
Removing .DS_Store
JanosJiri 5c2bbfe
testing 7
JanosJiri a8210ea
Test proposed by ChatGPT
JanosJiri 73746d1
Merge branch 'master' into testing
JanosJiri cf9c4d6
Changing test files
JanosJiri c28c122
Merge remote-tracking branch 'origin/testing' into testing
JanosJiri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
name: CI | ||
|
||
on: | ||
push: | ||
branches: [ "main" ] | ||
pull_request: | ||
|
||
permissions: | ||
contents: read | ||
|
||
env: | ||
FORCE_COLOR: 1 | ||
|
||
jobs: | ||
intel_build: | ||
name: Intel OneAPI build | ||
runs-on: ubuntu-20.04 | ||
env: | ||
FC: mpiifort | ||
APT_PACKAGES: >- | ||
intel-oneapi-compiler-fortran | ||
intel-oneapi-mpi | ||
intel-oneapi-mpi-devel | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 2 | ||
|
||
- name: Install fftw | ||
run: | | ||
echo "Entering FFTW folder" | ||
cd fftw | ||
echo "Unpacking FFTW" | ||
tar -xf fftw.tar.gz | ||
echo "Compiling FFTW" | ||
cd fftw | ||
bash compile.sh | ||
|
||
- name: Add Intel repository | ||
run: | | ||
wget https://apt.repos.intel.com/intel-gpg-keys/GPG-PUB-KEY-INTEL-SW-PRODUCTS-2023.PUB | ||
sudo apt-key add GPG-PUB-KEY-INTEL-SW-PRODUCTS-2023.PUB | ||
rm GPG-PUB-KEY-INTEL-SW-PRODUCTS-2023.PUB | ||
echo "deb https://apt.repos.intel.com/oneapi all main" | sudo tee /etc/apt/sources.list.d/oneAPI.list | ||
sudo apt-get update | ||
|
||
- name: Install Intel oneAPI compiler | ||
run: | | ||
sudo apt-get install ${{ env.APT_PACKAGES }} | ||
source /opt/intel/oneapi/setvars.sh | ||
printenv >> $GITHUB_ENV | ||
|
||
- name: Build ABIN | ||
run: cd src/; make clean && make |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
*.o | ||
*.mod | ||
src/*.o | ||
src/*.mod | ||
src/qdyn | ||
*.DS_Store |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could use the
setup-fortran
action instead of all this setup.https://github.com/fortran-lang/setup-fortran
(I've been meaning to try it out for ABIN but did not get to it yet, would be great if you could test it here!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, nothing escapes your attention on GitHub. Thanks for the idea, I will give it a try, but I first need to understand how the whole stuff works. I copied that from ABIN but I need the
fftw
library first which I somehow can't figure out now. :DThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FFTW probably needs to be compiled with the same compiler as qdyn, so you need to move the FFTW compilation after you setup the intel compiler.
I'd recommend just copying the
fftw_build
job from ABIN, where I install fftw via apt to avoid compilation. In that case, you need to use to default gfortran compiler otherwise the installed fftw apt package will not be compatible.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, for some reason I am getting emails for each change on the qdyn repo :-D I was getting a lot of them today. :-P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, cool, thanks for the advice, I will try it someday.
I had no idea you were watching this repo. I was just playing around thinking no one would see it. :D