-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-util/electron-20.3.12-r1: Not possible to build with python 3.11.x #238
Comments
Please try patching it like this: --- a/tools/grit/grit/util.py
+++ b/tools/grit/grit/util.py
@@ -209,7 +209,7 @@
mode = 'rb'
encoding = None
else:
- mode = 'rU'
+ mode = 'r'
with io.open(filename, mode, encoding=encoding) as f:
return f.read() |
BTW, what issue are you referring to exactly? There is an issue on ppc64 platform, that makes electron-19 and electron-20 the only options for now (and it is the reason I keep them in overlay). If you're on amd64 platform, you could try building vscode with electron-25. You need to build manually with the help of |
I did see that you had mentioned you were able to build VSCode with Electron 25 in another issue, however when I tried it with |
As I've written above you need to replace Alternatively you could try downgrading system node. |
Sorry, I hadn't looked in the ebuild for |
|
@PF4Public I've read through the issues you created about the But when I re-ran [4/4] Building fresh packages...
[20/20] ⠈ windows-foreground-love
[8/20] ⠈ @vscode/windows-process-tree
[18/20] ⠈ electron
[14/20] ⠈ node-pty
[5/20] ⠈ @vscode/spdlog for a while and then reported error D:\vscode\node_modules\electron: Command failed.
Exit code: 1
Command: node install.js
Arguments:
Directory: D:\vscode\node_modules\electron
Output:
ReadError: The server aborted pending request
at IncomingMessage.<anonymous> (D:\vscode\node_modules\got\dist\source\core\index.js:809:31)
at Object.onceWrapper (node:events:632:28)
at IncomingMessage.emit (node:events:530:35)
at origin.emit (D:\vscode\node_modules\@szmarczak\http-timer\dist\source\index.js:43:20)
at IncomingMessage._destroy (node:_http_incoming:224:10)
at _destroy (node:internal/streams/destroy:121:10)
at IncomingMessage.destroy (node:internal/streams/destroy:83:5) Btw, I've tried multiple times and it always ends with this error. So I made this comment under this issue page to find some help. |
I tried some other versions ( And the version |
I solved this by switching my node version from |
@NriotHrreion You seem to be on Windows. On Linux I solve this issue by running electron as node: |
I need to build Electron 19 or 20 due to the tree sitter issue in VSCode. As far as I understand, the only workaround for this currently is to use a version of Electron <21, however it is possible to build neither version with the current default version of Python from the main Gentoo repository. Both fail with the same error as shown in the attached logs:
ValueError: invalid mode: 'rU'
.build.log
The text was updated successfully, but these errors were encountered: