Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounds documentation needs clairification #546

Closed
shoepfl opened this issue Jun 24, 2022 · 2 comments
Closed

Bounds documentation needs clairification #546

shoepfl opened this issue Jun 24, 2022 · 2 comments

Comments

@shoepfl
Copy link

shoepfl commented Jun 24, 2022

Hey there,

i am confused by the current documentation for the parameter bounds of the PEtab files. The current statemet in the docs is that the bounds "Must be provided in linear space, independent of parameterScale."

From this I would expect that also my given linear bounds are respected, but they are subsequently converted to the parameterScale and therefore the bound i give in linear space is not respected but its transformation to the other scale.

Maybe one sentence for the clairification would be sufficient here, that states one has to be careful here that the given linear bound is not the one that is respected later (but its transformation to the parameterScale).

@dweindl
Copy link
Member

dweindl commented Jun 27, 2022

Hi @shoepfl, would the proposed changes in https://github.com/PEtab-dev/PEtab/pull/547/files clarify things for you?

@shoepfl
Copy link
Author

shoepfl commented Jun 27, 2022

Thanks @dweindl looks perfekt for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants