Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I configure the font size to be used when printing a plain text file? #308

Closed
electrotype opened this issue May 13, 2024 · 5 comments · Fixed by #310
Closed

Can I configure the font size to be used when printing a plain text file? #308

electrotype opened this issue May 13, 2024 · 5 comments · Fixed by #310
Assignees
Labels
bug Something isn't working

Comments

@electrotype
Copy link

I'm trying to increase the font size using "print.fontSize": "13pt" but it doesn't seem to change anything when printing a simple ".txt" file.

I've tried in Firefox and in Brave, same result.

Am I missing something?

Thanks in advance

@PeterWone
Copy link
Collaborator

PeterWone commented May 14, 2024

Print uses a framework for document renderer plugins. The one for plaintext is separate from the one that renders source code using highlightjs. The renderer plugins are also responsible for generating stylesheets from settings and it would appear I didn't think to bring out the font family and size for plaintext.

We're having release pipeline hassles at the moment but I'll certainly add this to the backlog!

@PeterWone PeterWone added the bug Something isn't working label May 14, 2024
@steveculshaw
Copy link

Confirm I'm seeing the same issue in Edge

@PeterWone PeterWone self-assigned this May 20, 2024
@PeterWone
Copy link
Collaborator

PeterWone commented May 20, 2024

See also #309

Both are addressed by updating the plaintext document renderer to link the bundled/settings.css resource also used by the source code document renderer.

This stylesheet is generated from a template into which system settings are copied. Specifically, these settings

image

While hooking this up I also applied a CSS class pre.plaintext which applies both the font settings and the whitespace: pre-wrap attribute, which should make Steve a happy camper.

image

Specifically, tab size depends on this
image

No, I haven't sorted out the CICD pipeline. It's going to be a manual release because things are getting ridiculous.

@PeterWone
Copy link
Collaborator

Issue response times have been long lately partly due to the borked build pipeline and partly due to things at work and at home. If you are well pleased with Print and the way it's evolving please consider leaving a favourable review - especially if you have something specific to note.

Negative feedback belongs here in the issues where I can do something about it - so thank you for helping

@steveculshaw
Copy link

steveculshaw commented May 21, 2024

Thanks for all the hard work 👍
Will do ... DONE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants