Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Printing from the command palette always prints the entire document. #290

Closed
dc6c opened this issue Feb 28, 2024 · 3 comments
Closed

Printing from the command palette always prints the entire document. #290

dc6c opened this issue Feb 28, 2024 · 3 comments
Assignees
@PeterWone
Labels
bug Something isn't working

Comments

@dc6c
Copy link

dc6c commented Feb 28, 2024

I can print just the selection by clicking on the printer icon or the context menu, but choosing the command "Printing: Print" from the palette always prints the entire document. Is this by design? I didn't see it mentioned in the manual.

Name: Print
Id: pdconsec.vscode-print
Version: 0.11.18
@PeterWone PeterWone added the bug Something isn't working label Feb 28, 2024
@PeterWone
Copy link
Collaborator

It is previously undefined. Command triggered behaviour should be as consistent as possible with mouse triggered behaviour so let's call it a bug.

@PeterWone PeterWone self-assigned this Mar 1, 2024
@PeterWone PeterWone linked a pull request Mar 1, 2024 that will close this issue
check for selection #291
Closed
PeterWone added a commit that referenced this issue Mar 9, 2024
@PeterWone
Webpack5 and highlightjs 11 compatibility problems #299
72b7c2a 
Update localisation support #298
Update unit test support #297
Update Action versions #293
Printing from the command palette always prints the entire document. #290
@PeterWone
Copy link
Collaborator

FINALLY released this to marketplace. Please check it works on your machine.

@dc6c
Copy link
Author

dc6c commented May 21, 2024

Yep, printing from the palette now handles the selection, thank you! (Print v0.11.28.) I'll close this issue as resolved.

@dc6c dc6c closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PeterWone PeterWone

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

check for selection PDConSec/vsc-print
2 participants
@PeterWone @dc6c