Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line Numbers "Inherit" not working as expected #207

Closed
pcsanza opened this issue Apr 29, 2023 · 3 comments · Fixed by #211
Closed

Line Numbers "Inherit" not working as expected #207

pcsanza opened this issue Apr 29, 2023 · 3 comments · Fixed by #211
Assignees
Labels
bug Something isn't working

Comments

@pcsanza
Copy link

pcsanza commented Apr 29, 2023

I apologize if this is "operator error" on my part - but I do think I am using this extension as intended. And yes, I did read the manual.

If I set line number setting to No, then no line numbers print. Cool.
If I set line number setting to Yes, then line number print. They print if I print the whole file or print just a selection. Cool.
If I set line number setting to Inherit, then line numbers do NOT print, even when line numbers are visible in the editor.

Workaround for now is to use Yes and No explicitly, but I would much prefer to inherit from the editor. Ideas what I might be doing wrong?

Screenshot showing editor:
editor

Screenshot showing print rendering with line number setting = Inherit
print-with-inherit

Screenshot showing print rendering with line number setting = Yes
print-with-yes

I get the same result whether I print a selection or print the whole file. Using Edge browser (latest) on a Windows 10 platform. Using latest version of the Print extension at time of this writing (v0.11.1). And if it matters, the code is using SystemVerilog syntax highlighting as provided by the Verilog-HDL/SystemVerilog/Bluespec SystemVerilog v1.11.4 extension.

Here are the particulars regarding my VS Code:
vscode_version

@PeterWone
Copy link
Collaborator

Hmmm, yes. Inherit used to do exactly what you expected it to, but it appears to be broken. I'll have to look into it.

@PeterWone PeterWone added the bug Something isn't working label May 1, 2023
@PeterWone PeterWone self-assigned this May 1, 2023
@PeterWone PeterWone changed the title Line Numbers not working as expected Line Numbers "Inherit" not working as expected May 1, 2023
@PeterWone
Copy link
Collaborator

I've fixed this. It will appear in a future release, but the release will be delayed by the fact that I need another setting to control what happens when there isn't an editor corresponding to the print job, such as printing folders or selections of multiple files.

When "inherit" was conceived folder and multi-selection printing didn't exist, and hardly anyone uses the file explorer to print just one file without opening it so I didn't notice the undefined case.

@stevenlis
Copy link

I'm having the same issue with v0.11.1, even with "print.lineNumbers": "on".

Version: 1.78.0
Commit: 252e5463d60e63238250799aef7375787f68b4ee
Date: 2023-05-03T20:15:29.774Z
Electron: 22.4.8
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Darwin arm64 22.4.0
Sandboxed: No

Chrome:

Version 112.0.5615.137 (Official Build) (arm64)

PeterWone added a commit that referenced this issue May 12, 2023
@PeterWone PeterWone linked a pull request May 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants