Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print a selection is not working. #142

Closed
YRFT opened this issue Jul 23, 2022 · 8 comments · Fixed by #143
Closed

Print a selection is not working. #142

YRFT opened this issue Jul 23, 2022 · 8 comments · Fixed by #143
Assignees

Comments

@YRFT
Copy link

YRFT commented Jul 23, 2022

The full-document print is working as expected.

But getting below error when I print a selection.

TypeError: Cannot read properties of undefined (reading 'asHtml')
    at g.<anonymous> (/home/bo/.vscode/extensions/pdconsec.vscode-print-0.9.26/dist/extension.js:2:1202382)
    at Generator.next (<anonymous>)
    at i (/home/bo/.vscode/extensions/pdconsec.vscode-print-0.9.26/dist/extension.js:2:1200323)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

I reopened the vscode and the browser, but still the same.

@YRFT
Copy link
Author

YRFT commented Jul 23, 2022

It's weird that when printing the files of other folders, this extension is working as expected. I think the problem is nothing to do with this extension. I'll close this issue.

Thank you for this awesome extension.

@YRFT YRFT closed this as completed Jul 23, 2022
@PeterWone PeterWone reopened this Jul 24, 2022
@PeterWone
Copy link
Collaborator

@YRFT I can reproduce this. You've definitely found a bug.

@PeterWone PeterWone self-assigned this Jul 24, 2022
@YRFT
Copy link
Author

YRFT commented Jul 24, 2022

Thank you for your work on this.

@PeterWone
Copy link
Collaborator

@YRFT would you mind grabbing the latest release and confirming for me that printing of a text selection is now working for you? The issue was auto closed when I merged the fix, it works for me here but there's nothing like third party checks. If it's still not right I'll reopen it.

@YRFT
Copy link
Author

YRFT commented Jul 26, 2022

I have installed the latest version of this extension (i.e. 0.9.27). Printing a selection is working now.

Thanks for your work.

@PeterWone
Copy link
Collaborator

Not at all. Thank you for helping us find and fix problems, instead of simply leaving a bad review. My next action is to figure out how to check this in our integration tests (it's not the first time I've broken selection printing while working on other things).

@PeterWone
Copy link
Collaborator

Incidentally, if you decide to write a review after you've used it for a while, write the sort of review you'd hope to read if you were still choosing an extension.

And if you have ideas for new features, don't be shy about opening an issue. Anything at all; if it's too hard I'll explain why and if it isn't then I'll credit you when it's released.

@YRFT
Copy link
Author

YRFT commented Jul 27, 2022

OK. Thanks, again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants