-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print a selection is not working. #142
Comments
It's weird that when printing the files of other folders, this extension is working as expected. I think the problem is nothing to do with this extension. I'll close this issue. Thank you for this awesome extension. |
@YRFT I can reproduce this. You've definitely found a bug. |
Thank you for your work on this. |
@YRFT would you mind grabbing the latest release and confirming for me that printing of a text selection is now working for you? The issue was auto closed when I merged the fix, it works for me here but there's nothing like third party checks. If it's still not right I'll reopen it. |
I have installed the latest version of this extension (i.e. Thanks for your work. |
Not at all. Thank you for helping us find and fix problems, instead of simply leaving a bad review. My next action is to figure out how to check this in our integration tests (it's not the first time I've broken selection printing while working on other things). |
Incidentally, if you decide to write a review after you've used it for a while, write the sort of review you'd hope to read if you were still choosing an extension. And if you have ideas for new features, don't be shy about opening an issue. Anything at all; if it's too hard I'll explain why and if it isn't then I'll credit you when it's released. |
OK. Thanks, again. |
The full-document print is working as expected.
But getting below error when I print a selection.
I reopened the vscode and the browser, but still the same.
The text was updated successfully, but these errors were encountered: