3rdparty/ccc: Backport some fixes #12033
Merged
+90
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Dependencies
chaoticgd
force-pushed
the
ccc_backports
branch
from
e5af611
to
3494ba4
Compare
Mrlinkwii
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
DWARF support is in the works but will still likely take a few months to be ready for prime time. In the meantime, I thought I would backport some crash fixes just for PCSX2.
The bounds checking bugs were found via fuzzing, so I think are unlikely to affect any games, but I still think it's nice to get them fixed. The assertion fix makes CCC crash more cleanly if an assertion were to fail, since previously it called exit which PCSX2 doesn't like very much.
Rationale behind Changes
Fix some bugs.
Suggested Testing Steps
You could test some of the games listed in my original symbol table PR #10224 and open the debugger.