Debugger: Fix loading symbols from ELF files other than the boot ELF #11986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoticgd
force-pushed
the
fix_loading_extra_elf_symbols
branch
from
6b5878b
to
f8e247b
Compare
chaoticgd
changed the title
chaoticgd
changed the title
F0bes
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This fixes an unfortunate typo in SymbolImporter.cpp. Previously, instead of loading symbol from the file specified it would just try to load symbols from the boot ELF again.
Rationale behind Changes
Suggested Testing Steps
Test that loading extra ELF files in the debug analysis settings dialog works.