From d920fe6c5ea0547500044584c3cb2fc8e766a9a7 Mon Sep 17 00:00:00 2001 From: Ziemas Date: Thu, 19 Oct 2023 04:05:34 +0200 Subject: [PATCH] SPU2: Pass reverb input by value --- pcsx2/SPU2/Reverb.cpp | 12 ++++++------ pcsx2/SPU2/defs.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/pcsx2/SPU2/Reverb.cpp b/pcsx2/SPU2/Reverb.cpp index 9126d50148da1..8f4440ed248fd 100644 --- a/pcsx2/SPU2/Reverb.cpp +++ b/pcsx2/SPU2/Reverb.cpp @@ -66,19 +66,19 @@ __forceinline s32 V_Core::RevbGetIndexer(s32 offset) return x & 0xf'ffff; } -StereoOut32 V_Core::DoReverb(const StereoOut32& Input) +StereoOut32 V_Core::DoReverb(StereoOut32 Input) { if (EffectsStartA >= EffectsEndA) { return StereoOut32::Empty; } - auto input = clamp_mix(Input); + Input = clamp_mix(Input); - RevbDownBuf[0][RevbSampleBufPos] = input.Left; - RevbDownBuf[1][RevbSampleBufPos] = input.Right; - RevbDownBuf[0][RevbSampleBufPos | 64] = input.Left; - RevbDownBuf[1][RevbSampleBufPos | 64] = input.Right; + RevbDownBuf[0][RevbSampleBufPos] = Input.Left; + RevbDownBuf[1][RevbSampleBufPos] = Input.Right; + RevbDownBuf[0][RevbSampleBufPos | 64] = Input.Left; + RevbDownBuf[1][RevbSampleBufPos | 64] = Input.Right; bool R = Cycles & 1; diff --git a/pcsx2/SPU2/defs.h b/pcsx2/SPU2/defs.h index 2d08792db2b97..b2a8a5840c290 100644 --- a/pcsx2/SPU2/defs.h +++ b/pcsx2/SPU2/defs.h @@ -495,7 +495,7 @@ struct V_Core // -------------------------------------------------------------------------------------- StereoOut32 Mix(const VoiceMixSet& inVoices, const StereoOut32& Input, const StereoOut32& Ext); - StereoOut32 DoReverb(const StereoOut32& Input); + StereoOut32 DoReverb(StereoOut32 Input); s32 RevbGetIndexer(s32 offset); StereoOut32 ReadInput();