Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import dot has gone again in 1.2.0 release! #165

Closed
loriab opened this issue May 1, 2018 · 6 comments
Closed

import dot has gone again in 1.2.0 release! #165

loriab opened this issue May 1, 2018 · 6 comments

Comments

@loriab
Copy link
Contributor

loriab commented May 1, 2018

I believe that the relative dot import .pyparsing added in #164 should be in the v1.2.0 release here

@arnfinn
Copy link
Contributor

arnfinn commented May 1, 2018

It is here #164, not yet merged.

Cherry pick from master

@loriab
Copy link
Contributor Author

loriab commented May 1, 2018

But the dot problem was discovered before the release tag. Why mint a tag with a known bug? I know how to get at the commit, was just trying to package pcmsolver from a tag, rather than from a commit or from a tag + patch.

@loriab loriab mentioned this issue May 1, 2018
5 tasks
@arnfinn
Copy link
Contributor

arnfinn commented May 1, 2018

The release branch was made right before the patch came into master, so I believe we just forgot to cherry pick it before the release was minted. Not sure if @robertodr is active today, to make a new release?

@loriab
Copy link
Contributor Author

loriab commented May 1, 2018

I think he's back in town tonight. Dropped him a note on psi4/psi4#988 for when he can do a new tag. Just working from my fork now and calling it 1.2.0rc2. Thanks for your help.

@robertodr
Copy link
Member

Apologies, was too hasty in preparing the tag to catch this one... I'll mint 1.2.1 ASAP

@arnfinn
Copy link
Contributor

arnfinn commented May 9, 2018

Fixed here: 3b76ff7

@arnfinn arnfinn closed this as completed May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants