Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making scripts such as pcmsolver.py configuration-state-less #111

Closed
bast opened this issue Dec 3, 2017 · 2 comments
Closed

Consider making scripts such as pcmsolver.py configuration-state-less #111

bast opened this issue Dec 3, 2017 · 2 comments
Milestone
v1.2.0

Comments

@bast
Copy link
Member

bast commented Dec 3, 2017

Currently these scripts are configured where paths to the binary is set at configure time. For context see #110.

Alternatives:

  • paths are configurable using CLI at runtime
  • use relative paths

Motivation:

  • configuration is simpler
  • development is simpler since you don't risk modifying a file that is not used or a file that is not tracked
@bast bast mentioned this issue Dec 3, 2017
Merged
2 tasks
@bast
Copy link
Member Author

bast commented Dec 3, 2017

In other words I think that configuring foo.py.in into foo.py with absolute paths is an anti-pattern. IMO the better solution is to use either relative paths or receive path information from the outside (CLI).

@robertodr robertodr added this to the v1.2.0 milestone Dec 3, 2017
@robertodr robertodr mentioned this issue Feb 6, 2018
Merged
9 tasks
@robertodr
Copy link
Member

Fixed in #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
2 participants
@robertodr @bast