Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxies and interceptors MUST NEVER be explicitly requested in constructors #8

Open
Wohlie opened this issue Apr 24, 2020 · 0 comments
Open

Proxies and interceptors MUST NEVER be explicitly requested in constructors #8

Wohlie opened this issue Apr 24, 2020 · 0 comments

Comments

@Wohlie
Copy link

Wohlie commented Apr 24, 2020

Hi, relating to magento coding guidelines "2.5. Proxies and interceptors MUST NEVER be explicitly requested in constructors." and must be defined via di.xml.

https://github.com/PAYONE-GmbH/magento-2-simple-protect/blob/master/Model/SimpleProtect/SimpleProtect.php#L98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Wohlie