Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust tests #2

Open
eyalkoren opened this issue Jun 8, 2023 · 0 comments
Open

Adjust tests #2

eyalkoren opened this issue Jun 8, 2023 · 0 comments

Comments

@eyalkoren
Copy link
Contributor

@P1llus note that the end result of elastic/elasticsearch#96171 was different from what this test currently reflects.

ecs-data-stream-mappings.json and string-to-keyword-dynamic-mapping.json were eventually removed.
The former was replaced with adding the data_stream fields' mappings to logs-mappings.json and the latter was instead appended to the end of ecs-dynamic-mappings.json.

The fix would not only be to remove them and their usage, but also to either avoid testing data_stream fields, or adding them somehow otherwise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalkoren