Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Stack Trace #92

Closed
roend83 opened this issue Jul 11, 2017 · 4 comments
Closed

Error Stack Trace #92

roend83 opened this issue Jul 11, 2017 · 4 comments

Comments

@roend83
Copy link

roend83 commented Jul 11, 2017

Outputting the stack trace on error here is causing my build output to be totally useless when there are nested run-sequence tasks. I'm getting thousands of lines of stack trace outputted. Is there an easy way to turn this off? I'd be happy to send a PR to make this configurable or off by default.

@OverZealous
Copy link
Owner

Hey there!

I'll be honest, that line has been modified back and forth so many times, I don't really want to change it too much. I'll look at an easy way to configure it.

Would you be OK with a global configuration, so changing it one place changes it everywhere that runSequence is used? I envision a usage like this:

var runSequence = require('run-sequence');
runSequence.configure({ showErrorStackTrace: false });

This way I could store a simple hash of configuration options and not have to deal with per-usage configuration. This would also open the door to some other options people have wanted, without making everything too complicated.

@roend83
Copy link
Author

roend83 commented Jul 24, 2017 via email

@OverZealous
Copy link
Owner

Nah, I know how I want to handle this, so I'll see if I can get it built tonight. I've got some other non-code things I want to make changes to at the same time.

@OverZealous
Copy link
Owner

OverZealous commented Jul 24, 2017

OK, should be published now. Just pull down v2.1.0.

It's even a bit simpler, just do runSequence.options.showErrorStackTrace = false; to suppress those traces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants