Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to xarray 0.17 and drop python 3.6 #592

Closed
aulemahal opened this issue Nov 18, 2020 · 2 comments · Fixed by #682
Closed

Upgrade to xarray 0.17 and drop python 3.6 #592

aulemahal opened this issue Nov 18, 2020 · 2 comments · Fixed by #682
Assignees
Labels
standards / conventions Suggestions on ways forward
Milestone

Comments

@aulemahal
Copy link
Collaborator

Some of our code involving xarray's apply_ufunc raise the following warnings:

 FutureWarning: ``output_sizes`` should be given in the ``dask_gufunc_kwargs`` parameter. It will be removed as direct parameter in a future version.

The change would be quite easy.

I am not aware of any other future change in xarray that could impact xclim, but those could added to this issue.

@aulemahal aulemahal self-assigned this Nov 18, 2020
@aulemahal aulemahal added this to the v0.22 milestone Nov 18, 2020
@Zeitsperre Zeitsperre added the standards / conventions Suggestions on ways forward label Nov 19, 2020
@Zeitsperre Zeitsperre modified the milestones: v0.22, v0.23 Dec 7, 2020
@tlogan2000 tlogan2000 modified the milestones: v0.23, v0.25 Jan 18, 2021
@aulemahal
Copy link
Collaborator Author

aulemahal commented Jan 18, 2021

The next xarray version (either 0.16.3 or 0.17) will drop python 3.6. The master branch has dropped it as of pydata/xarray#4720.
I'm guessing will have to do the same soon after.

@Zeitsperre
Copy link
Collaborator

The next xarray version (either 0.16.3 or 0.17) will drop python 3.6.

This will cause some formatting changes and will mean changes across all our xarray-based projects. Might be good to get acquainted with the newer features we can start making use of: https://www.python.org/dev/peps/pep-0537/#features-for-3-7

@aulemahal aulemahal modified the milestones: v0.25, v0.27 Mar 30, 2021
@aulemahal aulemahal changed the title Preemptively adapt to newer xarray. Upgrade to xarray 0.17 and drop python 3.6 Mar 30, 2021
@Zeitsperre Zeitsperre mentioned this issue Apr 6, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
standards / conventions Suggestions on ways forward
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants